Add charging and preconditioning actions to Teslemetry #144184
Conversation
Bre77
changed the title
Bre77
force-pushed
the
t-charge-schedule-service
branch
from
59dcc5d to
250d025
Compare
Bre77
force-pushed
the
t-charge-schedule-service
branch
from
250d025 to
a72fe9d
Compare
Bre77
force-pushed
the
t-charge-schedule-service
branch
from
a72fe9d to
91fe192
Compare
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| - "[%key:common::time::monday%]" | ||
| - "[%key:common::time::tuesday%]" | ||
| - "[%key:common::time::wednesday%]" | ||
| - "[%key:common::time::thursday%]" | ||
| - "[%key:common::time::friday%]" | ||
| - "[%key:common::time::saturday%]" | ||
| - "[%key:common::time::sunday%]" |
There was a problem hiding this comment.
Correct me if I'm wrong, but I think this is not recommended.
So far I have only seen these in strings.json:
"selector": {
"days_of_week": {
"options": {
"monday": "[%key:common::time::monday%]",
"tuesday": "[%key:common::time::tuesday%]",
"wednesday": "[%key:common::time::wednesday%]",
"thursday": "[%key:common::time::thursday%]",
"friday": "[%key:common::time::friday%]",
"saturday": "[%key:common::time::saturday%]",
"sunday": "[%key:common::time::sunday%]"
}
}
}
There was a problem hiding this comment.
Is days_of_week actually a core selector? https://www.home-assistant.io/docs/blueprint/selectors/
I found references to it in custom integrations but its undocumented in core.
There was a problem hiding this comment.
As I wrote, you should keep the selector as it was and only update the strings.json to reference the common strings instead of redefining "Monday" to "Sunday".
|
Hey @joostlek any chance we can finish this review before beta? |
| - "[%key:common::time::monday%]" | ||
| - "[%key:common::time::tuesday%]" | ||
| - "[%key:common::time::wednesday%]" | ||
| - "[%key:common::time::thursday%]" | ||
| - "[%key:common::time::friday%]" | ||
| - "[%key:common::time::saturday%]" | ||
| - "[%key:common::time::sunday%]" |
There was a problem hiding this comment.
translation references only work in strings.json
use a translation key here
There was a problem hiding this comment.
How do you translate selector values? I cant find any examples or references on how to do that? https://developers.home-assistant.io/blog/2023/07/11/translating-services/
I have removed everything not-related to the 4 new services and will put them in seperately. |
Proposed change
Add charging and preconditioning actions to Teslemetry
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: