Add charging and preconditioning actions to Teslemetry #144184
Conversation
Bre77
changed the title
Bre77
force-pushed
the
t-charge-schedule-service
branch
from
59dcc5d to
250d025
Compare
| "fields": { | ||
| "device_id": { | ||
| "description": "Vehicle to schedule.", | ||
| "name": "Vehicle" |
There was a problem hiding this comment.
As there are quite some duplicate strings now you could replace them with references.
A good approach is to define your own "common" section within the strings.json and then reference from there.
This keeps the references shorter and easier to manage.
See https://github.com/home-assistant/core/blob/dev/homeassistant/components/habitica/strings.json as a good example.
This would result in "[%key:component::teslemetry::common::vehicle%]" here and similar down the "services" section.
For strings that are just used identically in two actions you can x-ref within those.
This way you force translations to be consistent just like your original English strings. And it saves translators quite some time as we just copy the source with a single click in Lokalise for most strings.
There was a problem hiding this comment.
Ive started on the existing strings here: #144361
Bre77
force-pushed
the
t-charge-schedule-service
branch
from
250d025 to
a72fe9d
Compare
Proposed change
Add charging and preconditioning actions to Teslemetry
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: